Throw error when attempting to redefine ReactOnRails #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenochiavone
force-pushed
the
rubenochiavone/throw-error-when-redefining-react-on-rails
branch
2 times, most recently
from
f8d635f to
58b1d5a
Compare
3 tasks
justin808
requested changes
Jul 21, 2023
There was a problem hiding this comment.
shakapacker and not webpacker
There was a problem hiding this comment.
I moved the new troubleshooting docs to docs/javascript/troubleshooting-when-using-shakapacker.md, but kept the old one since it is related to webpacker. See c6d7da9.
node_package/src/ReactOnRails.ts
Outdated
| throw new Error(` | ||
| The ReactOnRails value exists in the ${ctx} scope, it may not be safe to overwrite it. | ||
|
|
||
| This could be caused by setting Webpack's optimization.runtimeChunk to "true" or "multiple" - please check your Webpack configuration. |
There was a problem hiding this comment.
This could be caused by setting Webpack's optimization.runtimeChunk to "true" or "multiple," rather than "single." Check your Webpack configuration.
There was a problem hiding this comment.
Done in cbde473.
rubenochiavone
force-pushed
the
rubenochiavone/throw-error-when-redefining-react-on-rails
branch
from
58b1d5a to
972fabb
Compare
rubenochiavone
changed the title
Webpack configuration could cause react-on-rails to be imported multiple times in each runtime chunk, leading to the global ReactOnRails variable being overridden and client rendering crashes. This should be avoided by relying on a single runtime chunk. Read more at #1558.
rubenochiavone
force-pushed
the
rubenochiavone/throw-error-when-redefining-react-on-rails
branch
from
cbde473 to
38910f2
Compare
justin808
deleted the
rubenochiavone/throw-error-when-redefining-react-on-rails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Webpack configuration could cause react-on-rails to be imported multiple times in each runtime chunk, leading to the global ReactOnRails variable being overridden and client rendering crashes. This should be avoided by relying on a single runtime chunk.
Read more at #1558.
Pull Request checklist
Screenshots
This change is